Repository navigation
ci(release): refuse a stable that differs from its newest beta - #3543
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
version.py checkonly needs a published beta on the line before a stable X.Y.0. A pick merged after the newest beta ships in X.Y.0 without any tester running it.Change
version.py checkrefuses a stable X.Y.0 whose tree differs from the newest publishedvX.Y.0-beta.NoutsideCHANGELOG.mdandchangelog.d/. The error names the paths.RELEASING.md, What a tag runs: theverifybullet names the new refusal.Verified
python3 -m unittest test_versioninscripts/releaseon Python 3.9: the new case for a pick after the newest beta fails on main and passes here.test_a_stable_needs_a_published_betanow tags the beta it publishes, since the check diffs against that tag.