Repository navigation
ci(release): hold a line's first stable to its newest beta - #3548
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After a refused
v0.82.0(a pick landed after the newest beta), the tag stays and no beta of 0.82.0 can follow. The refusal said "ship that in a beta first", which cannot happen, andv0.82.1then passed with the same untested pick because patches were exempt. Follow-up to #3543.Change
version.py checkholds every stable on a line to its newest published beta until a stable tag on the line has matched it. A fix after a matching X.Y.0 that failed later in its run still ships as the next number.release/X.Y, then tag the next number.RELEASING.md, What a tag runs: the verify bullet names the wider refusal.Verified
python3 -m unittest test_versionon Python 3.9. New cases: X.Y.1 carrying the late pick is refused and X.Y.2 with it reverted builds; X.Y.1 after a matching, unpublished X.Y.0 builds.test_a_stable_refuses_a_change_after_its_newest_published_betachanged with the new wording.Not in this PR
scripts/ci/check-changelog.py).