Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH and WSL shells with Wave shell integration do not receive
COLORTERM=truecolor. The default added in #3141 is applied byWaveshellLocalEnvVars, which remote shell startup bypasses. Applications that use this variable to detect color depth can therefore select a reduced-color rendering mode.Set the default in the shared remote shell swap token, before merging user environment settings. This covers integrated SSH and WSL shells, including durable SSH sessions. Explicit
cmd:envvalues take precedence, and local shells retain their existing handling of inheritedCOLORTERM.Related to #2090; follows up on the local-shell implementation in #3141. I searched open and closed issues and PRs for
COLORTERM, truecolor, and SSH color support and found no existing PR covering this remaining path.Validation:
go test ./pkg/blockcontroller ./pkg/shellexec ./pkg/util/shellutilpassed.go vet ./pkg/blockcontroller ./pkg/shellexec ./pkg/util/shellutilpassed.gofmtandgit diff --checkpassed.Draft pending validation in the desktop app. GitHub Copilot CLI was the affected application that prompted this investigation: setting
COLORTERM=truecolorchanged its initial appearance, but colors still changed after a message. AddingFORCE_COLOR=3also produced visual problems. The cause of that continuing rendering behavior remains unconfirmed; this change addresses the missing capability advertisement and does not establish a complete Copilot rendering fix.