Skip to content

fix: advertise truecolor in integrated remote shells - #3567

Closed
dss539 wants to merge 1 commit into
wavetermdev:mainfrom
dss539:fix/remote-shell-colorterm
Closed

dss539 wants to merge 1 commit into
wavetermdev:mainfrom
dss539:fix/remote-shell-colorterm

Conversation

@dss539

@dss539 dss539 commented Oct 19, 2026

Copy link
Copy Markdown

SSH and WSL shells with Wave shell integration do not receive COLORTERM=truecolor. The default added in #3141 is applied by WaveshellLocalEnvVars, which remote shell startup bypasses. Applications that use this variable to detect color depth can therefore select a reduced-color rendering mode.

Set the default in the shared remote shell swap token, before merging user environment settings. This covers integrated SSH and WSL shells, including durable SSH sessions. Explicit cmd:env values take precedence, and local shells retain their existing handling of inherited COLORTERM.

Related to #2090; follows up on the local-shell implementation in #3141. I searched open and closed issues and PRs for COLORTERM, truecolor, and SSH color support and found no existing PR covering this remaining path.

Validation:

  • go test ./pkg/blockcontroller ./pkg/shellexec ./pkg/util/shellutil passed.
  • go vet ./pkg/blockcontroller ./pkg/shellexec ./pkg/util/shellutil passed.
  • gofmt and git diff --check passed.

Draft pending validation in the desktop app. GitHub Copilot CLI was the affected application that prompted this investigation: setting COLORTERM=truecolor changed its initial appearance, but colors still changed after a message. Adding FORCE_COLOR=3 also produced visual problems. The cause of that continuing rendering behavior remains unconfirmed; this change addresses the missing capability advertisement and does not establish a complete Copilot rendering fix.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dss539 dss539 closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant