Repository navigation
Conversation
zamuwelle
force-pushed
the
fix/forward-termination-signals
branch
from
October 18, 2026 21:26
9e2b64d to
617b698
Compare
Signals sent to the runner alone (kill <pid>, a supervisor, or docker stop) do not reach the task processes it started: the runner exits and the tasks keep running, holding ports and files. Ctrl-C in a terminal reaches them only because the terminal driver signals the whole foreground process group. The session now forwards SIGINT, SIGTERM, and SIGHUP to the registered task processes and cancels the run's tokens, replacing the terminal Ctrl-C handler. The run ends through the regular wait paths once the tasks exit. Each spawned task process is registered while it runs, so a signal is never forwarded to a reused pid (fspy::TrackedChild now exposes the child pid). Refs voidzero-dev/vite-plus#3090.
zamuwelle
force-pushed
the
fix/forward-termination-signals
branch
from
October 19, 2026 05:34
617b698 to
1f8c04c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals sent to the runner alone (kill , a supervisor, or docker stop) do not reach the task processes it started: the runner exits and the tasks keep running, holding ports and files. Ctrl-C in a terminal reaches them only because the terminal driver signals the whole foreground process group.
The session now forwards SIGINT, SIGTERM, and SIGHUP to the registered task processes and cancels the run's tokens, replacing the terminal Ctrl-C handler. The run ends through the regular wait paths once the tasks exit. Each spawned task process is registered while it runs, so a signal is never forwarded to a reused pid (fspy::TrackedChild now exposes the child pid).
Refs voidzero-dev/vite-plus#3090.