Repository navigation
test: fix flaky wait for a replica to follow - #268
Open
Totktonada wants to merge 1 commit into
Open
Totktonada wants to merge 1 commit into
Totktonada wants to merge 1 commit into
Conversation
The replica status check may get the `attempt to index field 'downstream' (a nil value)` error. The `downstream` field is added when the replica subscribes, a moment after registration in `_cluster`. The race in the check hits `200-master-replica.t`, `240-ro-on-disconnect.t` and `230-orphan-not-stalling-init.t`. A replica left running by a failed test may also fail the following tests. The race hits tarantool's integration workflow in CI from time to time. Drafted by an LLM, conducted and corrected by the commit author.
Col-Waltz
approved these changes
Oct 20, 2026
Col-Waltz
left a comment
Col-Waltz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replica status check may get the
attempt to index field 'downstream' (a nil value)error. Thedownstreamfield is added when the replica subscribes, a moment after registration in_cluster.The race in the check hits
200-master-replica.t,240-ro-on-disconnect.tand230-orphan-not-stalling-init.t. A replica left running by a failed test may also fail the following tests.The race hits tarantool's integration workflow in CI from time to time.
Drafted by an LLM, conducted and corrected by the commit author.