Skip to content

improvement(sim-cli): publish each command's path aliases and renamed paths in the command inventory - #9251

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/cli-inventory-aliases
Oct 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/cli-inventory-aliases

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The CLI command inventory (packages/sim-cli/scripts/print-command-inventory.ts), which the mothership worker builds its agent grammar from, now publishes each command's commander aliases per path segment (pathAliases, aligned with path) and the retired paths the CLI still runs as that command (renamedFrom)
  • Without them the worker refused or misread spellings this CLI runs: files mv, workflows folders ls, kb …, and renamed paths such as tables count create and workflows deployment list

Companion: simstudioai/mothership#767

Type of Change

  • Other: CLI inventory metadata for the worker grammar

Testing

  • reference.test.ts: the published aliases match the real CLI, and file mv … sends the same requests as files move … through the embedded CLI
  • reference.test.ts: each published renamed path resolves in buildProgram() to a hidden command running the same operation, and tables count create t1 sends the same requests as tables rows count t1
  • sim-cli vitest 485/485, tsc, biome, check:comment-hygiene and check:cli-docs pass
  • The worker's check:cli-inventory and check:contract-sync pass against this branch (344 commands)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 20, 2026 7:25pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

The CLI inventory now publishes alternate command spellings for the worker.

  • The command inventory now lists aliases and retired command paths.

No actionable issues found. The full PR diff was reviewed because the current head does not build on the previous review commit. No previous review threads were supplied. Tests were inspected, not run.

Reviews (2) · Last reviewed commit: "improvement(sim-cli): publish each comma..." · Reviewed by Greptile

@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Oct 20, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

  • ❌ simstudioai/mothership#767 — OPEN, not merged (targets staging) — improvement(worker): read sim_cli spellings the grammar allows one way, and name

… paths in the command inventory

The worker builds its agent grammar from this inventory and did not know that sim runs files mv, workflows folders ls or kb as their commands, or still runs retired paths such as tables count create and workflows deployment list as the commands they were renamed to, so it refused or misread them. Each command now carries the commander aliases of its path segments (pathAliases, aligned with path) and the paths it was renamed from (renamedFrom).
@waleedlatif1
waleedlatif1 force-pushed the improvement/cli-inventory-aliases branch from 7264686 to c5aaf7d Compare October 20, 2026 19:25
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 57cc81e into staging Oct 20, 2026
54 of 55 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/cli-inventory-aliases branch October 20, 2026 20:07

This branch was previously deployed

1 inactive deployment
Preview — c5aaf7d5 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant