Skip to content

fix(chat): keep previous messages stable when sending - #9249

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/fix-chat-followup-shift
Oct 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/fix-chat-followup-shift

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep suggested follow-ups in place when sending a message switches their heading to a collapsible control.
  • Preserve the dismiss button's space on inactive question cards so long titles do not rewrap and pull later content upward.

Type of Change

  • Bug fix

Testing

  • Browser verification with the actual components and compiled app CSS: suggested follow-ups shifted up 4px before the fix and 0px afterward; unanswered question cards shifted up 20px at a title-wrapping boundary before the fix and 0px afterward.
  • Verified collapse/expand, active question dismissal, and hidden inactive dismiss controls.
  • Existing question and special-tag tests: 79 passed.
  • Full root test suite, lint, type-check, all 60 audits, and block registry audit.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 20, 2026 7:01pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Keeps earlier chat messages steady when sending.

  • Question cards keep their header space when they become inactive.
  • Suggested follow-ups stay in place when their heading changes.

Reviews (2) · Last reviewed commit: "fix(chat): preserve inactive question ca..." · Reviewed by Greptile

@waleedlatif1 waleedlatif1 changed the title fix(chat): prevent suggested follow-ups from shifting on send fix(chat): keep previous messages stable when sending Oct 20, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 58b3485 into staging Oct 20, 2026
44 of 45 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-chat-followup-shift branch October 20, 2026 19:08

This branch was previously deployed

1 inactive deployment
Preview — f69c2671 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant