Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@lavenzg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125707029. |
meta-codesync
Bot
changed the title
lavenzg
force-pushed
the
export-D125707029
branch
from
October 19, 2026 16:56
acbbe68 to
e1caa60
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Oct 19, 2026
Summary: `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Differential Revision: D125707029
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Oct 19, 2026
Summary: Pull Request resolved: react#59146 `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Differential Revision: D125707029
lavenzg
force-pushed
the
export-D125707029
branch
2 times, most recently
from
October 19, 2026 19:32
3ca23be to
963c3ad
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Oct 19, 2026
Summary: `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Reviewed By: avp Differential Revision: D125707029
Summary: Pull Request resolved: react#59146 `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Reviewed By: avp Differential Revision: D125707029
lavenzg
force-pushed
the
export-D125707029
branch
from
October 19, 2026 19:36
963c3ad to
112c59d
Compare
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 19, 2026
Summary: X-link: react/react-native#59146 `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Reviewed By: avp Differential Revision: D125707029 fbshipit-source-id: 15d3f83ac23d8bceb24e9e13a1f67dc4b61bb3b8
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 19, 2026
Summary: X-link: react/react-native#59146 `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Reviewed By: avp Differential Revision: D125707029 fbshipit-source-id: 15d3f83ac23d8bceb24e9e13a1f67dc4b61bb3b8
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 19, 2026
Summary: X-link: react/react-native#59146 `global.String` could be overridden. We always need to check the return type before casting to `jsi::String`. Changelog: [Internal] Reviewed By: avp Differential Revision: D125707029 fbshipit-source-id: 15d3f83ac23d8bceb24e9e13a1f67dc4b61bb3b8
Collaborator
|
This pull request was successfully merged by @lavenzg in 1fcf9b8 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 1fcf9b8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
global.Stringcould be overridden. We always need to check the return type before casting tojsi::String.Changelog: [Internal]
Reviewed By: avp
Differential Revision: D125707029