Repository navigation
gh-114258: Update AC to support @critical_section for tp_iternext - #159962
Merged
Merged
Conversation
corona10
requested review from
AA-Turner,
erlend-aasland and
rhettinger
as code owners
October 20, 2026 20:59
bedevere-app
Bot
added
type-feature
Member
Author
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
This looks good for tp_iternext/__next__, but I think we need to make some changes in order to support all the slots described in the issue. We could also wait to do those until we actually need them if you'd prefer, but that would mean larger diffs for those PRs (rather than just one big one now).
corona10
enabled auto-merge (squash)
October 20, 2026 22:44
corona10
disabled auto-merge
October 20, 2026 23:15
corona10
enabled auto-merge (squash)
October 20, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.