Repository navigation
Conversation
reusable-psd-ci.yml and reusable-license-check.yml declare no secrets and read none, so secrets: inherit handed both jobs every org and repo secret. Repos created from this template copy the line.
Review: CI: pass no secrets to the org reusablesFindings: none. The diff is clean. What I read
Security and data handling: the change reduces secret exposure to the two jobs. It touches no student data, logs, or external services. CI gates: no tests removed, skipped, or weakened. Both jobs still run on the same triggers. I did not run the workflows. The reusable-workflow check was done by reading the files via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The psd-ci and license-check callers pass
secrets: inheritto the org reusables. Neitherreusable-psd-ci.ymlnorreusable-license-check.ymldeclares or reads a secret, so the line only hands those jobs every org and repo secret, and every repo made from this template copies it. This removes the line from both callers.Tested before this PR: psd401/psd-dev-standards#102 (license-check without secrets, passed) and psd401/psd-crowdstrike-infra#3 (psd-ci and license-check without secrets, passed). The same line is in 44 workflow files across 23 repos (psd401/psd-dev-standards#101); the templates are where new repos pick it up.