Repository navigation
Fix stale attachment IDs causing 404 errors in Emails section - #106
Open
MeloveGupta wants to merge 2 commits into
Open
MeloveGupta wants to merge 2 commits into
MeloveGupta wants to merge 2 commits into
Conversation
Change get_or_create to update_or_create in parse_and_add_attachments() so that attachmentid and filename are refreshed when the mail archive re-indexes attachments. Previously, defaults were only applied on record creation, leaving stale IDs that pointed to non-existent attachments. Add regression tests verifying attachment metadata is updated correctly.
The separate test file mostly covered behaviour that was already there. The one new thing, refreshing a stale attachment id, is now checked as part of the existing `refresh_single_thread` test, which exercises the real code path. This also drops the unrelated reformatting of `forms.py`, which is already on main.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the archives assign a new id to an attachment we already know about, the stored
attachmentidandfilenamewere never updated, becauseparse_and_add_attachmentsusedget_or_create. That resulted in attachment links in the Emails section returning a 404. Now it usesupdate_or_create, so the attachment info is refreshed whenever the thread gets a new email.