Repository navigation
[Bugs] editor: HUD note rows stay visible while shortcuts are collapsed - #1102
Merged
Merged
Conversation
The More shortcuts collapse kept only the first row and active rows, so a '!' row (why a window can't wrap this wall end: 'No wall meets here') went behind More shortcuts. A note says what is in the way, not a key to press, so it always shows; More shortcuts appears only when collapsing hides a row.
It saved window and document as undefined and assigned them back, leaving both keys on globalThis. perf-monitor.test then read 'window' in globalThis as a window, skipped its alias and threw when it ran after this file, which is the order bun takes in some checkouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Editor-side fix for part of private-editor #1099.
HUD note rows always show (
packages/editor/src/components/ui/helpers/contextual-helper-panel.tsx)!row in the contextual HUD (the corner-window note, e.g. "No wall meets here") explains why something won't happen; it isn't a key to press. The collapsed HUD used to keep only the first row plus active rows, so the note got folded under More shortcuts and the user never saw why the window wouldn't wrap the corner. Note rows are now always part of the collapsed set.helper-manager.test.tsxcover both rules, using the realcornerHintRows('free_end')rows.Viewer test isolation (
packages/viewer/src/components/viewer/render-error.test.tsx)window/documentby assigning their saved value. Under Bun that value isundefined, so the globals stayed defined asundefinedand a later file's'window' in globalThischeck would think a window exists. The test now deletes the keys when they were absent before.Not in this PR: the other two items in #1099 (wall presets no longer auto-armed when the Build tab opens in
apps/editor/components/build-tab.tsx, and the duplicateproject_key) are not on this branch.build-tab.tsxstill arms the first build tool on open.How to test
bun test packages/editor/src/components/ui/helpers/helper-manager.test.tsx: 7 pass.Ran locally:
bun run check-types(13/13 tasks pass) andbun run test. The test run has one failure,floor-foundation-support.test.ts› "a drag of -0.02 m lands on release". It fails the same way onorigin/main, passes when run alone, and is unrelated to this diff.Screenshots / screen recording
Not added yet.
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
UI-only HUD collapse rules plus test teardown; no auth, data, or runtime product paths beyond helper panel display.
Reviewed by Cursor Bugbot for commit 5526cd6. Bugbot is set up for automated code reviews on this repo. Configure here.