Repository navigation
feat: resolve package manager bins from package manifests - #926
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Signed-off-by: Aschenbath <Aschenbath@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a package manager moves its executable, Corepack can download a valid tarball and then fail with
MODULE_NOT_FOUNDbecause it uses a configured path. Tarball installations now read executable paths from the downloaded package'spackage.json, allowing layouts such as pnpm's.cjs→.mjsmigration to work without a Corepack release.bindeclarations, including scoped package names.Validation on Node.js 24.20.0 using the repository's existing
node_modules:node node_modules/typescript/bin/tsc --noEmitpassed.node node_modules/eslint/bin/eslint.js --max-warnings=0passed.git diff --checkpassed.NOCK_ENV=replay, retries disabled: 10 files passed; 214 tests passed and 1 existing expected failure (215 total).mainimplementation withERR_MODULE_NOT_FOUNDforbin/pnpm.mjs; it passes with this change.Full-suite command:
The local, uncommitted preload retains outbound proxy access for the existing live npm signing-key check while clearing inherited proxy settings for fixture CLIs. No tests are skipped or changed for this environment adjustment. The expected failure is already declared with
it.failsintests/main.test.ts:75(should refuse to download a known package manager from a URL in package.json).Closes #775.
Implementation and automated validation were performed by Codex.