Repository navigation
fix: ignore LOCALAPPDATA outside Windows - #913
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Contributor
|
This account has opened more than 10 PRs in the last 24 hours. This looks like bot activity, and will result in a ban if the behavior continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Linux (including WSL) or macOS inherits LOCALAPPDATA, Corepack currently puts its cache there instead of the platform's normal cache directory. This can send WSL downloads to a Windows filesystem and cause permission errors.
Use LOCALAPPDATA only on Windows. Preserve the existing precedence of COREPACK_HOME and XDG_CACHE_HOME, and retain the Windows home-directory fallback. Document the full selection order and add 11 unit cases covering Linux, macOS, Windows, and explicit overrides. The Linux/macOS regression cases fail before the fix.
Validation on Node.js 24.20.0 (Linux):
The platform-selection unit tests simulate process.platform. Local test setup isolates inherited proxy settings from CLI fixtures while retaining proxy access for the live npm-key check; compilation caches are stored under .git. No tests were skipped or modified for these environment adjustments.
Closes #673.
Implementation and automated validation were performed by Codex.