Repository navigation
fix: respect conflicting lockfiles when auto-pinning - #910
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Contributor
|
This account has opened more than 10 PRs in the last 24 hours. This looks like bot activity, and will result in a ban if the behavior continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
COREPACK_ENABLE_AUTO_PIN=1, running another package manager in a project identified by a lockfile could silently pin that other manager inpackage.json.Skip automatic pinning when
package-lock.json,npm-shrinkwrap.json,pnpm-lock.yaml, oryarn.locknext to the selected manifest belongs to a different manager. The requested command still runs, andcorepack useremains available for an explicit selection. Document the behavior and add 13 CLI regressions for all three managers, matching/conflicting lockfiles, multiple lockfiles, nested directories, and explicit selection.Validation on Node.js 24.20.0:
NOCK_ENV=replay: 9 files passed; 184 tests passed and 1 existing expected failure.tsc --noEmit: passed.--max-warnings=0: passed.Local test setup isolates inherited proxy settings from CLI fixtures while retaining access for the live npm-key check. Compilation caches were disabled to accommodate the small temporary filesystem. No tests were skipped or modified for these environment adjustments.
Closes #695