Skip to content

Rust Port: Fix Zellij 0.45 session attachment - #282

Open
wesm wants to merge 2 commits into
mainfrom
zellij-exact-attach
Open

wesm wants to merge 2 commits into
mainfrom
zellij-exact-attach

Conversation

@wesm

@wesm wesm commented Oct 17, 2026

Copy link
Copy Markdown
Member
  • Restore attachment to the selected Zellij session with 0.45.1 across native Linux, WSL, and SSH. The old attach -- <name> syntax now treats the name as an initial command.
  • Reject creation and attachment for names the CLI cannot address: names beginning with - (except - itself), help, and options. Existing sessions remain visible and killable; the dialog explains the restriction.
  • Verify the actual session identity after reopening among multiple live sessions, preserve spaces and quotes, and test the SSH command through its shell quoting layers. Linux X11 acceptance and screenshots use Zellij 0.45.1; Windows desktop and live SSH acceptance remain unverified.
  • Rust and website checks pass locally. The separate Python/Swift tooling gates still fail in unchanged Linux tooling or stop for missing tools.

Native Linux Ghosthub attached to the selected Zellij 0.45.1 session

The creation dialog explains unsupported Zellij names

Zellij 0.45 interprets an attach argument after -- as an initial command.
Reopening with multiple active sessions can therefore show a chooser instead
of selecting the requested session.

The current CLI cannot express option-like or reserved attach names. Reject
them explicitly so a failed attachment cannot select a different session or
mark its host unavailable. Keep existing sessions visible and killable.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:14 — with GitHub Actions Active
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:14 — with GitHub Actions Active
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:15 — with GitHub Actions Active
The native Linux guide should show the application users now operate,
including the parser restriction that prevents attaching some names.
Use the inspected captures attached to the current Rust-port PR.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:16 — with GitHub Actions Active
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:16 — with GitHub Actions Active
@wesm
wesm deployed to sandbox-image-promotion-status October 17, 2026 13:16 — with GitHub Actions Active
@roborev-ci

roborev-ci Bot commented Oct 17, 2026

Copy link
Copy Markdown

roborev: Combined Review (20520ad)

Verdict: No findings at or above medium severity.


Reviewers: 3x codex, codex (security) | Synthesis: codex | Total: 3m9s

This branch was successfully deployed

1 active deployment
sandbox-image-promotion-status — 20520ad4 Deployed Oct 17, 2026 by wesm via Reconcile promotion authorization #1913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant