Repository navigation
fix(auth): validate tenant and provider IDs and URL-encode query parameters - #996
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances security and robustness by validating tenant and provider IDs as safe URL segments and refactoring query parameter construction to use dictionaries, ensuring proper URL encoding. The review feedback suggests further improving consistency in tenant_mgt.py by replacing manual validation checks in update_tenant with the newly introduced _auth_utils.validate_tenant_id helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tenant_idandprovider_idvalues are valid URL path segments before constructing Auth and Identity Platform management request paths.paramsdictionary / URL query encoding forlist_oidc_provider_configs,list_saml_provider_configs, andproject_managementapp listing requests so query parameters such aspageTokenare properly percent-encoded.Testing
tests/test_tenant_mgt.py,tests/test_auth_providers.py, andtests/test_project_management.py.