Repository navigation
land: redact-completion-previews - #596
Open
aft-alfonso[bot] wants to merge 3 commits into
Open
aft-alfonso[bot] wants to merge 3 commits into
aft-alfonso[bot] wants to merge 3 commits into
Conversation
Reuse the Rust credential redactor for completion/wake previews and mask exact secret-named values from the selected child environment. Keep the secret list on the live task only; restarted tasks withhold preview text while retaining status and recovery pointers. Raw capture files and status/read results are unchanged. Watch matching remains raw. Presentation is masked before context selection and before persistence/push, including matches split at scanner chunk edges. A hit requires one intact capture read: update the existing I/O assertion explicitly for that added security work. Replay tests now assert withheld text while retaining routing/count/offset/ack checks; the binary parity fixture normalizes the newly visible per-fixture storage roots. Narrow non-live sk- matching to key-length strings to preserve ordinary sk- words. Verified Linux Rust redactor/background/subc-bash gates, binary tests and list envelopes; Windows cross-check; bridge build, all three typechecks and lint. Pi and bridge unit suites passed. OpenCode full suite had unrelated mock/order, permission-ask and timeout failures; the new host wake cases passed, and controls independently reddened OpenCode 1, OpenCode 2, Pi, exact-env masking and raw-token watch presentation. See delivery evidence for counts and the persistent permission fixture failure. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
…views Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Map watch source offsets against the intact lossy UTF-8 decoding, expand ranges to character boundaries, and use checked slicing before rendering context. Cover the reported 64 KiB emoji cut, randomized multibyte cuts, invalid bytes, and out-of-range endpoints. Restore cached recovery markers and pipeline warnings after masking a completion body. The live failing-pipeline regression exercises compressed and raw previews, queued completions and snapshots. Existing tests retain their contracts; all five new regressions pass alongside the bash_background and list_envelope gates. Mutation controls independently reddened the exact Unicode, randomized-cut, pipeline-warning, and recovery-marker tests. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Masks background task completion previews and watch push text so credentials never reach OpenCode or Pi; raw output files and
bash_statusresults are unchanged.Details
sk-redaction to length-qualified keys so ordinarysk-words remain visible.Written for commit 27ebc01. Summary will update on new commits.
The changes appear safe to merge; no new actionable issues were found.Summary
Masks background completion previews and watch text before shortening them. Raw output files and
bash_statusresults remain unchanged.Reviews (2) · Last reviewed commit: "mason: preserve safe watch ranges and ma..." · Reviewed by Greptile