Repository navigation
docs/test: trim PostgreSQL IAM follow-ups from #421 - #459
Merged
Merged
Conversation
Follow-up to #421: keep the user-facing behavior (per-connection tokens for PostgreSQL, pool refresh for MySQL/MariaDB, SSO re-login) and drop implementation detail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWd28U5E4UgGFeyimwDnFN
Replace the tsx subprocess and embedded script with two in-process tests that cover what the mocked signer tests can't: a rotated shared credentials file is re-read (ignoreCache), and a credential_process that failed succeeds on retry. Env-var and missing-profile cases are already covered by aws-rds-signer.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWd28U5E4UgGFeyimwDnFN
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation remains accurate and the revised tests preserve the intended credential-refresh coverage.
0 open findings
What changed in this PR
Condenses PostgreSQL IAM documentation and simplifies real-SDK credential refresh tests.
Changes:
- Clarifies token refresh behavior across supported databases.
- Replaces subprocess testing with isolated in-process Vitest cases.
| File | Description |
|---|---|
docs/config/toml.mdx |
Streamlines IAM authentication guidance. |
src/utils/__tests__/aws-rds-credentials.test.ts |
Tests credential rotation and login recovery in process. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #421.
docs/config/toml.mdx: condense the 27-line PostgreSQL IAM section to 4 lines covering the user-facing behavior (per-connection tokens for PostgreSQL, pool refresh for MySQL/MariaDB, SSO re-login then retry). Implementation detail (in-flight token sharing, socket-timeout vs. helper, env vars in other shells, MFA) is dropped;lazy/connection_timeoutalready have their own sections.src/utils/__tests__/aws-rds-credentials.test.ts: replace thenode --import tsxsubprocess with an embedded script by two in-process tests against the real SDK with isolated fake credential files (vi.stubEnv):ignoreCacheis removed; verified),credential_processsucceeds on retry after "login".The env-var and missing-profile cases are dropped —
aws-rds-signer.test.tsalready covers profile isolation with mocks.Validation: all unit tests pass (
pnpm test); the only failures are the Docker integration suites, which fail identically onmainin this environment.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWd28U5E4UgGFeyimwDnFN
Generated by Claude Code