Repository navigation
fix: send authorization_details as JSON in pushed_authorization_request - #904
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PushedAuthorizationRequests.pushed_authorization_request()sends its body asapplication/x-www-form-urlencoded. Whenauthorization_detailsis passed as a list,urlencode()writes the Python repr of the list ([{'type': 'money_transfer', ...}], single-quoted) instead of JSON. That is not the JSON array that RFC 9396 requires forauthorization_details.This change serializes a list
authorization_detailswithjson.dumps()before the request is sent, the same wayBackChannelLogin.back_channel_login()already does (#695). String values pass through unchanged.PushedAuthorizationRequests.pushed_authorization_request()(no signature change)test_with_authorization_detailsnow expects the JSON string.test_authorization_details_sent_as_jsonchecks the encoded request body that reachesrequests.request.References
authorization_detailsin back_channel_login #695authorization_detailsis a JSON array.Testing
poetry run pytest tests/authentication/test_pushed_authorization_requests.py: 5 passed. Without the source change,test_with_authorization_detailsandtest_authorization_details_sent_as_jsonfail.poetry run pytest tests/authentication: 113 passed.Not tested against a live tenant.