Repository navigation
[Test] Use consistent time units for asynchronous assertion flushes - #18905
Merged
jt2594838 merged 2 commits intoOct 19, 2026
Merged
Conversation
Register table schemas before sealing consensus LOAD files, including recovered tasks, so Pipe can enumerate their table data. Cover normal loads, recovery, and null tags with regression tests.
jt2594838
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestUtils compares elapsed milliseconds with a timeout expressed in seconds when deciding when to issue its one-time receiver flush. For a 600-second assertion, the threshold is only 300 milliseconds, so the flush happens on the first polling attempt instead of halfway through the wait. In IoTConsensusV2 batch mode, data arriving after that early flush can miss the flush needed for replica synchronization.
Use a shared seconds-to-milliseconds calculation in all eight asynchronous assertion flush checks, and add a regression test around the 300-second threshold. Changes are limited to TestUtils and its regression test.
Validation
mvn spotless:apply -P with-integration-tests -pl integration-testpassed.git diff --checkpassed.Full Daily IT verification: #18906 (https://github.com/apache/iotdb/actions/runs/39188054785).