Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1645
Proposed Changes
SimpleObjectInfo.CheckVisibilityto select the targets visible to the current viewer.count: 1, and page 2 is empty withcount: 1.Validation
Passed locally:
go test ./internal/service/comment ./internal/repo/repo_test -count=1(SQLite)go build ./...go vet ./...golangci-lint run ./internal/service/comment/... ./internal/repo/comment/... ./internal/repo/repo_test/...git diff --checkThe new service regression tests were also run against the old implementation and reproduced the incorrect counts and pagination.
MySQL/PostgreSQL tests were not run because the local Docker socket is inaccessible.
Trade-off
Each request checks all distinct comment targets for the profile user before querying the requested page. Request cost and the size of the SQL
INfilter therefore grow with the number of distinct targets; large-scale performance has not been benchmarked.Related: #1648 proposes another fix for the same issue.