Repository navigation
ci: compile AllPlugins on push only when plugins change - #3546
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every push to main or
release/**set up Go, built both native bridges and compiledAllPlugins, about 4 minutes of a macOS slot, even when no plugin input changed. PRs already skip that through thepluginsdetector.Change
AllPluginson a push only when thepluginsdetector is not false, as on a PR. A dispatch and a failed changes job still compile.pluginsdetector also watchesgenerate-project.sh,download-libs.sh,create-openssl-dylibs.sh,prepare-buildandsetup-xcodegen, which the plugin build reads. This closes the same gap on PRs.ci.md: macOS Tests, the detector and What runs where.Verified
test_detect_changed_paths.py: the newpluginscases fail on main's detector for those 5 paths and pass here. actionlint, shellcheck and agent-docs pass.Not in this PR
AllPluginscompiled at that commit. Release Build still compiles every registry plugin on each code push.